replace "endpoint_url" parameter in PurviewCollectionsClient class for "account_name" parameter #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r "account_name" parameter
|
Hi, @edobrynin-dodo thank you for your interest in PyApacheAtlas and willingness to contribute to the project! Unfortunately, this might not work as well for all users as there are some cases where we need to construct the endpoint url in advance (due to some internal naming conventions at Microsoft for our testing / internal versions of Purview). However, I agree, this could be simplified. I would gladly accept a solution that keeps it simple but limits the areas that would have to change the url if a user was specifying a different domain / sub-domain beyond the account name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use "account_name" parameter in core.PurviewClient class, because it's enough to build endpoint_url from it.
This PR applies the same logic to PurviewCollectionsClient class: you only need to pass account_name, and the endpoint url will be created inside the related functions